test: give the DTMF completion wait more headroom - #268
Merged
Conversation
RTCDtmfSenderTests waits one second for a tone sequence to complete. The longest sequence in the suite needs 720 ms of tone time, and timer scheduling plus the JNI callback add about 240 ms on top, so the bound leaves almost no margin and ordinary scheduling jitter is enough to cross it. The Intel macOS lane hit this twice in a row. The latch returns when the sequence completes, so a five second bound costs nothing when the test passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RTCDtmfSenderTestswaits one second for a tone sequence to complete, a bound introduced with the observer latch in a5cdb18. The longest sequence in the suite needs 720 ms of tone time. Timer scheduling and the callback into Java add about 240 ms on top, so the bound leaves roughly 50 ms of margin and ordinary scheduling jitter is enough to cross it.I hit this twice in a row on the Intel macOS lane in this run on my fork, both attempts, while the same tree passed everywhere else. The failing test's two sequences took 1.785 s together, which matches the estimate.
The change raises the wait to five seconds. The latch returns as soon as the sequence completes, so a passing test takes exactly as long as before, and only a real hang waits the full five seconds. Runs with this change passed the test on every lane, both with warm caches and cold. Green runs prove little for an intermittent failure, so the arithmetic above is the actual argument.